Skip to content

Make Spring integration tests use AbstractsValueProvider #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Makes Spring integration tests use AbstractsValueProvider (i.e. use instances of sub type where abstract types are expected).

How to test

Manual tests

Generate integration tests for OwnerController.processCreationForm(@Valid Owner owner, BindingResult result) in spring-petclinic project using PetClinicApplication configuration. There should be tests that use non-null values for BindingResult.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-fuzzing Issue is related to the fuzzing comp-spring Issue is related to Spring projects support labels Jul 20, 2023
@IlyaMuravjov IlyaMuravjov requested a review from Markoutte July 20, 2023 16:41
@IlyaMuravjov IlyaMuravjov merged commit 1de5cf9 into main Jul 21, 2023
@IlyaMuravjov IlyaMuravjov deleted the ilya_m/enable_abstracts_object_value_provider_for_spring branch July 21, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-fuzzing Issue is related to the fuzzing comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants